-
Notifications
You must be signed in to change notification settings - Fork 37
Use status, kill, start, and check for dmypy #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2b13abf
to
81503ba
Compare
Not calling status is something that changed some time ago with no particular reason as far as I can tell, so we can fix that. Why call start after kill, would the next run not do that anyway? Does this fix your issue? |
This change did fix my issues, I think run works fine as well but I definitely found it more confusing when debugging and trying to identify which process was the daemon and which was being submitted to the daemon. The bad interaction happens in the following scenario:
This continues until I stop editing files or I wait long enough for one of the dmypy tasks to fully index. It's a pretty rough experience for my project where the initial dmypy run takes several minutes, and during that time if I edit anything it starts over entirely. When I was debugging this is was helpful to have a |
Co-authored-by: StabbarN <[email protected]>
Co-authored-by: StabbarN <[email protected]>
534a971
to
8b70857
Compare
hello, I'm wondering if you have an idea of when you'll release a new version with this change? thanks! |
Now |
perfect, thanks! |
Fixes usage of dmypy so only one instance is started and they don't constantly kill eachother.
Fixes #44