Clean up dmypy daemon created in test. #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, forgot about this. |
|
Not sure why 3.7 does not work, but given mypy just dropped support for 3.7, we will as well. |
|
No apology needed. I tried reproducing the failure on Python 3.7 (granted, on macOS) and couldn't, so I am also not sure what happened during that run. Since we are dropping Python 3.7 support, I'll let it be for now. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a sequence of events:
dmypy, a daemon process is forked.test_dmypy_status_fileruns (anddmypyis not in PATH), this daemon is started from the test process.pytestis run and completes, there is a danglingpytestprocess which is running the daemon.pytestis run by the nix package manager, I observe the package manager waiting forever for this dangling process to complete.This commit does a best effort cleanup of the
dmypydaemon before the test is completed.