Skip to content

add prefix to config setting #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2020
Merged

add prefix to config setting #118

merged 2 commits into from
Sep 2, 2020

Conversation

heeplr
Copy link

@heeplr heeplr commented Apr 16, 2020

rename ERROR_404_HELP -> RESTX_ERROR_404_HELP (fixes #114)

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #118 into master will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   96.92%   96.85%   -0.07%     
==========================================
  Files          19       19              
  Lines        2697     2701       +4     
==========================================
+ Hits         2614     2616       +2     
- Misses         83       85       +2     
Impacted Files Coverage Δ
flask_restx/api.py 96.69% <50.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 858ac78...009c38e. Read the comment docs.

@heeplr
Copy link
Author

heeplr commented Apr 16, 2020

Maybe it would be better to not use DeprecationWarning but FutureWarning, so the warning is displayed on every startup, not only when testing. Not too sure.

@ziirish
Copy link
Contributor

ziirish commented Sep 2, 2020

Good catch, thanks!

@ziirish
Copy link
Contributor

ziirish commented Sep 2, 2020

Although could you please do a rebase so I can merge your changes?

[EDIT] Nevermind, I couldn't see the Update branch button on mobility, but using the "desktop mode" I see it.

@ziirish ziirish merged commit d62c7da into python-restx:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename ERROR_404_HELP to RESTX_ERROR_404_HELP for consistency
2 participants