Skip to content

Update example.rst #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Update example.rst #168

merged 1 commit into from
Jul 23, 2020

Conversation

Rich107
Copy link
Contributor

@Rich107 Rich107 commented Jul 3, 2020

Hi Maintainers!

After copying the example from the read the docs page I got the below error:

Error: While importing "app", an ImportError was raised:

Traceback (most recent call last):
  File "C:\Users\44780\PycharmProjects\muck-around-flask-restx\venv\lib\site-packages\flask\cli.py", line 240, in locate_app
    __import__(module_name)
  File "C:\Users\44780\PycharmProjects\muck-around-flask-restx\app.py", line 4, in <module>
    from werkzeug.contrib.fixers import ProxyFix
ModuleNotFoundError: No module named 'werkzeug.contrib'

Looks like this has been solved in commit e186dc48cc4680aa3a7ce4b3d6ad2f6f44992816 for the examples folder but not done in this example.

This is my first pull request so feedback welcome.

All the best
Rich

Hi Maintainers!

After copying the example from the read the docks page I got the below error:

Error: While importing "app", an ImportError was raised:

Traceback (most recent call last):
  File "C:\Users\44780\PycharmProjects\muck-around-flask-restx\venv\lib\site-packages\flask\cli.py", line 240, in locate_app
    __import__(module_name)
  File "C:\Users\44780\PycharmProjects\muck-around-flask-restx\app.py", line 4, in <module>
    from werkzeug.contrib.fixers import ProxyFix
ModuleNotFoundError: No module named 'werkzeug.contrib'

Looks like this has been solved in commit e186dc4 for the examples folder but not done in this example. 

This is my first pull request so feedback welcome. 

All the best
Rich
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          19       19           
  Lines        2696     2696           
=======================================
  Hits         2613     2613           
  Misses         83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b43ba...9aabddd. Read the comment docs.

@j5awry j5awry merged commit f0c08b1 into python-restx:master Jul 23, 2020
@j5awry
Copy link
Contributor

j5awry commented Jul 23, 2020

Thank you for the docs contribution! We did indeed get this changed in most places but missed this one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants