Make error handlers order of registration respected when handling errors #201
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an regular dict on error_handlers, both at Api and at Namespace, mean that which handler was not predictable. We had 2 error handlers, one for a generic service exception and one for a more specific exception that needed special care. Our registration worked some times, but not others, and this is the root cause. Here is a sample of what we had
and a route was raising
SomeSpecificError
. One sees ocurrences of one or the other message depending on what is returned from the dict were those errors are stored.