Added specs-url-scheme option for Api. #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DustinMoriarty
commented
Oct 9, 2020
DustinMoriarty
commented
- Support explicitly setting the scheme for specs_url for the swagger.json file for cases where the URL scheme does not resolve correctly such as when deploying on AWS ECS behind an elastic load balancer. Behavior is unchanged for cases where the keyword argument is left as None. See Need to Explicitly set Swagger specs_url Scheme When Deployed on Behind AWS Elastic Load Balancer. #237
- Added tests for the new behavior as well as to confirm the old behavior has not changed.
- Added docstrings.
- Formatted with black. This will effect the diff for a few other modules such as flask_restx/reqparse.py, flask_restx/model.py. flask_restx/inputs.py and some other locations in api.py.
- Added .python-version and .idea to .gitignore.
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 96.87% 96.88%
=======================================
Files 20 20
Lines 2724 2727 +3
=======================================
+ Hits 2639 2642 +3
Misses 85 85
Continue to review full report at Codecov.
|
mas15
approved these changes
Oct 26, 2020
|
@DustinMoriarty Hi, I cannot do that since I am not a maintainer. This project is abandoned and I would not expect this to be merged |
|
To bad. Thanks for letting me know. |
|
@j5awry : I updated this to get it up to date with the upstream. I do need maintainer approval to get it through the workflow checks and merge if you think this is something you would like to do. |
j5awry
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.