Cap aniso8601 for python 2.7 environments #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniso8601==8.1.0 * raises ValuError in case of non-string arguments passed to get_date_resolution and parse_date methods. It is ok for Python3 envs, but backward incompatible for Python 2.7 where we are passing unicode (at least in unittests). * https://bitbucket.org/nielsenb/aniso8601/src/master/CHANGELOG.rst
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 19 19
Lines 2705 2705
=======================================
Hits 2620 2620
Misses 85 85 Continue to review full report at Codecov.
|
j5awry
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aniso8601==8.1.0 * raises ValuError in case of non-string arguments
passed to get_date_resolution and parse_date methods.
It is ok for Python3 envs, but backward incompatible for Python 2.7
where we are passing unicode (at least in unittests).