-
Notifications
You must be signed in to change notification settings - Fork 338
No ".dev" should appear in package.json version number #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The ill-formed version number makes development annoying (always have to manually remove |
Thank you for the PR. However, this doesn't fix the issue, it only fixes immediate installs. Furthermore, it will incorrectly set this to be version 0.4.1, when it needs to be a pre-release version. we use any change proposal here will need to work in our release workflow: https://github.com/python-restx/flask-restx/blob/master/CONTRIBUTING.rst#release-process |
Thanks for the explanation. I checked out bumpr's documentation, it doesn't seem like it can use The easiest solution seems to put a warning message or a hack in the version string in the |
There's also an open bug against I'm assuming that noirbizarre isn't making updates. I've suggested moving off |
I mostly use setuptools_scm. It generates versions automatically based on the current git tag (for release versions) or how far it is from the last git tag (for dev versions). So, there shouldn't be any need to run any specific command to bump version number, just do git tag. It is maintained by PYPA so the probability of getting abandoned without transition guide is low. But I don't know whether it is possible to get it to work with npm's version string format. |
This is the error message I got when I ran `inv assets`: npm WARN Invalid version: "0.4.1.dev" npm WARN flask-restx No description npm WARN flask-restx No repository field. npm WARN flask-restx No README data npm WARN flask-restx No license field.
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 20 20
Lines 2730 2730
=======================================
Hits 2643 2643
Misses 87 87 Continue to review full report at Codecov.
|
This is the error message I got when I ran
inv assets
: