Skip to content

Using black formatting #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2020
Merged

Using black formatting #60

merged 2 commits into from
Feb 26, 2020

Conversation

SVilgelm
Copy link
Contributor

Fix #55

@SVilgelm SVilgelm mentioned this pull request Feb 15, 2020
Closed
@ziirish
Copy link
Contributor

ziirish commented Feb 15, 2020

I think it would make sense to replace the current lint step with black --check as another commit in this PR.

@SVilgelm SVilgelm force-pushed the black branch 9 times, most recently from 8158b36 to cb51a9c Compare February 16, 2020 02:15
@SVilgelm SVilgelm added the ci/cd Continuous Integration and Continuous Delivery tasks label Feb 16, 2020
@ziirish
Copy link
Contributor

ziirish commented Feb 19, 2020

Could you please rebase?
I think we'd also need to update the CONTRIBUTING guidelines stating that we are using black for the code formatting.

Thanks

Sergey Vilgelm added 2 commits February 19, 2020 06:13
Remove flake8 validation and add black instead
0d0b8f6 
Add a `checks` job in workflow to do a preliminary checks
Using black formatting
b6b92d5 
Run `black .` to format the current code with black
@j5awry
Copy link
Contributor

j5awry commented Feb 25, 2020

I reviewed based on the following:

  1. the github action
  2. making sure black was added to a requirements file

I didn't go through each format change, as I trust black (since i use it personally)

ziirish
ziirish approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@ziirish ziirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like @j5awry, I didn't review all the changes per say, just the interesting bits (CONTRIBUTING guidelines, workflows, etc.)

@ziirish ziirish merged commit 014eb95 into python-restx:master Feb 26, 2020
@SVilgelm SVilgelm deleted the black branch February 26, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziirish ziirish ziirish approved these changes

@j5awry j5awry j5awry approved these changes

@SteadBytes SteadBytes Awaiting requested review from SteadBytes

Assignees
No one assigned
Labels
ci/cd Continuous Integration and Continuous Delivery tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use black to enforce codestyle
3 participants
@SVilgelm @ziirish @j5awry