Fix Issue #75: Catch TypeError in marshalling #76
Conversation
|
@robyoung, thank you for contributing to flask-restx. I don't see any tests added to ensure MarshallingError is being raised. Since coverage didn't seem to go down, it appears to be a hole in the coverage. Could you contribute tests to ensure that the correct error is being raised? |
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 19 19
Lines 2696 2696
=======================================
Hits 2613 2613
Misses 83 83
Continue to review full report at Codecov.
|
When marshalling receiving a `MarshallingError` is much more useful than receiving the underlying exception directly as the `MarshallingError` has context about where it happened and it means all marshalling issues can be handled in one place. This change also catches `TypeError`s from the int and float formatters so that they are correctly turned into `MarshallingError`s.
|
@j5awry sorry for the delay in this. I have rebased on master and added a couple of tests. |
|
The drop in coverage makes no sense to me. This adds no new lines of code and adds tests to cover the new branches but the coverage reporter reports a drop in coverage on a completely different module. 🤔 |
|
No problem, codecov makes some early reports that don't reflect the whole test suite. |
|
Is there anything else that needs to happen before this can be merged? |
When marshalling receiving a
MarshallingErroris much more useful thanreceiving the underlying exception directly as the
MarshallingErrorhas context about where it happened and it means all marshalling issues
can be handled in one place.
This change also catches
TypeErrors from the int and float formattersso that they are correctly turned into
MarshallingErrors.See: #75