RawGit Deprecation #1002
RawGit Deprecation #1002
Conversation
Added a new Tooltip class to reference GeoJson feature properties, with tests, documentation, and examples. It's flexible, and can take field names, aliases, that can be turned on/off with the 'labels' boolean, a 'sticky' property, and can incorporate Javascript's .toLocaleString() functionality if desired. The same string can be passed for each object with the 'text' variable as well if you'd rather not use the 'fields'. Also updated the GeoJson JS template to reference this Tooltip object, and added a test to make sure that the values passed exist in the properties.
Further linting.
Seems like maybe the f-string usage in the geojson fields assertion check is causing the build failure. Testing normal string concatenation.
Reverted accidental vega_parse change.
Fixed docstring indentation.
Updating Tooltip docstring broke 120 char line limit.
Removed trailing white space.
Updating my fork to current Master.
…iLang.xml, ide.general.xml, Default.xml, project.default.xml, diff.xml, git.xml, other.xml, jdk.table.xml, Default.xml, code.style.schemes, find.xml, ui.lnf.xml, laf.xml, filetypes.xml, projectView.xml, vcs.xml, editor.codeinsight.xml, notifications.xml, keymap.xml, editor.xml, github_settings.xml, debugger.xml
…, IntelliLang.xml, ide.general.xml, Default.xml, project.default.xml, diff.xml, git.xml, other.xml, jdk.table.xml, Default.xml, code.style.schemes, find.xml, ui.lnf.xml, laf.xml, filetypes.xml, projectView.xml, vcs.xml, editor.codeinsight.xml, notifications.xml, keymap.xml, editor.xml, github_settings.xml, debugger.xml" This reverts commit 76c9622.
…ithub.com/jtbaker/folium to local" This reverts commit 84811a0.
Conflicts: vcs.xml
|
@jtbaker I'm not sure you meant for all those commits to be in this PR, right? |
|
@jtbaker the xml's ended up being committed again :) Can you remove them? After that I'll add a changelog entry and merge. Thanks for making this PR! By the way, what do you use to do git stuff? If you'd like we could maybe share our workflows, see what can be improved. |
That is a good question! I'm a big fan of fork-branch-PR. Sometimes I don't even have a master on my fork so I'm forced to always fetch the latest master-dev and branch from there when adding a new feature or fixing a bug. PS: would you two be available for a live meeting to discuss that and more about |
|
I removed the xmls and added a line to the changelog. Good to merge IMO.
That would be nice! What's a good channel to set this up, Gitter? I should check more often or enable notifications then. |
|
Merged! Thanks @jtbaker, glad we got this done now already :) |
Yep. We can use gitter. Unless you have another suggestion. |
|
@Conengmo sorry for the delay on my part, it has been a really busy work week. Thanks for the help! I think early on in my history with the project I accidentally committed the XMLs to my master branch and it has hosed my repository ever since and it is seemingly impossible to get them out of version control - I've tried rebasing my master and PRing from the
That sounds great @ocefpaf, I'd like to be a part of it. I'm on US on CDT time. |
That is one way to fix it. The other one is to remove your git checkout upstream/master
git branch -D master
git checkout -b master
git push --set-upstream origin master -fPS: consider having a development cycle without |
|
I'm available them. I'm on Central European time so that's 19:00 for me if I'm not mistaken. |
|
Perfect |
Swapped all references to
rawgit.comtorawcdn.githack.com. Pretty sure I got everything. Closes #997.