Skip to content

Fix tests #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Fix tests #1012

merged 2 commits into from
Nov 7, 2018

Conversation

Conengmo
Copy link
Member

@Conengmo Conengmo commented Nov 6, 2018

It seems the branca.six module got deprecated or broken or whatever, so the Travis build fails.

ImportError while importing test module '/tmp/tests/test_features.py'.
[.......]
tests/test_features.py:14: in <module>
    from branca.six import text_type
E   ModuleNotFoundError: No module named 'branca.six'

In a recent branca PR it was replaced with the regular six package.
python-visualization/branca#49

So I did that here as well, see if it works.

Copy link

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Conengmo
Copy link
Member Author

Conengmo commented Nov 7, 2018

Thanks for the review @ccclauss! I'll go ahead and merge this, so the other PR's can update from master and have their tests pass.

@Conengmo Conengmo merged commit 110a90a into python-visualization:master Nov 7, 2018
@Conengmo Conengmo deleted the fix-tests branch November 7, 2018 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants