add options to draw control #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conengmo
requested changes
Feb 9, 2019
There was a problem hiding this comment.
Thanks for your PR @EtsuNDmA, nice to have some more options for this plugin. I made some comments, mainly to get the coding style consistent with the rest of folium. Hope you can take a look at it. When it's done I'm confident we're going to merge this.
Conengmo
added
waiting for changes
ocefpaf
reviewed
Feb 10, 2019
|
Hi! @Conengmo, I took into account your comments. Also add an example to dockstring |
Conengmo
approved these changes
Feb 25, 2019
|
Looks good @EtsuNDmA! I'll merge it after checking it one last time, but I don't think any more changes are necessary. |
Conengmo
added
ready
ocefpaf
force-pushed
the
master
branch
3 times, most recently
from
53546b8 to
9f2299a
Compare
|
Thanks @EtsuNDmA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options for draw control. Also add custom filename for geojson file