Skip to content

Use jquery.com CDN instead of Google #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

Conengmo
Copy link
Member

@Conengmo Conengmo commented Mar 9, 2019

Closes #1085. Use jQuery's own CDN instead of Googles so folium is more easy to use in China.

@Conengmo
Copy link
Member Author

Conengmo commented Mar 9, 2019

@ocefpaf any comments? Do you want to merge this?

@ocefpaf
Copy link
Member

ocefpaf commented Mar 9, 2019

@ocefpaf any comments? Do you want to merge this?

LGTM. We just need to fix the failing test and let's merge it.

@Conengmo
Copy link
Member Author

Conengmo commented Mar 9, 2019

Ah right, my bad. Didn't update the URL in the test template. Should be fixed now.

@ocefpaf ocefpaf merged commit 3043e16 into python-visualization:master Mar 9, 2019
@ocefpaf
Copy link
Member

ocefpaf commented Mar 9, 2019

I'm planning a minor release next week with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants