Prevent installing 0.9 on dropped Python versions #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Mar 16, 2019
* Use pip's `python_requires` argument should work for users with fairly recent pip version. * Otherwise raise an exception in `setup.py` when it is executed by an old Python version. * As a final catch raise an exception on importing folium when the Python version is lower than 3.
ocefpaf
reviewed
Mar 17, 2019
| @@ -66,11 +64,6 @@ script: | |||
| pytest /tmp -vv --ignore=tests/notebooks/test_notebooks.py ; | |||
| fi | |||
|
|
|||
| - if [[ $TRAVIS_JOB_NAME == 'legacy-python' ]]; then | |||
|
Thanks @Conengmo! Those safeguards against old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python_requiresargument should work for users with fairly recent pip version.setup.pywhen it is executed by an old Python version.This is from the guidelines from https://python3statement.org/practicalities/