Adding popup to lines, test_line

[themiurgo]

This adds the possibility to visualise popups when clicking on lines.

Tests still pass. Let me know if there's anything I need to change to get this merged.

[ocefpaf]

Looks good. I just tested it out:

http://nbviewer.ipython.org/gist/ocefpaf/1360f49bb2bb632a7736

Our tests are lacking a line test. If you think it is a low hanging fruit can you add one and test your modification? If not I will merge "as is" and add one later.

[themiurgo]

Yes, true, no tests. Also, I think there's no documentation about line, I had to see the code to use it. Will see if I can quickly write something in the next couple of days.

[ocefpaf]

Great. If not just open an issue and ping me to get this merged.

[themiurgo]

Managed to add tests and documentation. Let me know if they need some edits, otherwise they're good to go.

[ocefpaf]

Python 3.3 is giving us a slap on the wrist. Probably something simple to solve. Do you have an env there to check this and fix? If not I can do later today.

[themiurgo]

Not yet, I have been procastinating the Py3 installation. I guess it's about time to get it installed. 😀

[ocefpaf]

... and now it is Python 3.4 it is hard to make py3k happy!

[themiurgo]

What's funny is that the only file that I changed since the last commit (which Travis doesn't complain about), is the index.rst in the docs. I guess some doctest is failing?

[ocefpaf]

Nope, we do not run doctest. The tests are simply:

https://github.com/themiurgo/folium/blob/lines_popup/.travis.yml#L26

Probably something 💩 in our tests.

If you are done editing I will merge this and check it here.

[themiurgo]

Yes, you can go ahead.
On Wed, 13 May 2015 at 10:02 Filipe [email protected] wrote:

Nope, we do not run doctest. The tests are simply:

https://github.com/themiurgo/folium/blob/lines_popup/.travis.yml#L26

Probably something [image: 💩] in our tests.

If you are done editing I will merge this and check it here.

—
Reply to this email directly or view it on GitHub
#122 (comment)
.

[ocefpaf]

Thank @themiurgo!