Update url wms data #1259
Merged
Update url wms data #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sknzl , thanks for helping out with this. Can you run the notebook and include that in this PR? That way the version we show here is up to date. |
Conengmo
added
the
waiting for changes
|
I just tried updating the notebook but the new server seems down as well... https://pae-paha.pacioos.hawaii.edu/thredds/ If it stays like this we should not test this notebook anymore, it's casing to many headaches. |
|
I updated the notebook, here's the updated version: https://nbviewer.jupyter.org/github/sknzl/folium/blob/update-url-wms-data/examples/WmsTimeDimension.ipynb If the tests pass I'll merge this. |
Conengmo
removed
the
waiting for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem already described here in PR #1256 .
URL to wms data is outdated because server moved. This also makes Travis CI fail.