new vega lite version #1525
Merged
new vega lite version #1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conengmo
approved these changes
Nov 3, 2021
|
The any adjustments to the failing tests from my end? seem to be different than my changes. |
stickler-ci
reviewed
Feb 18, 2022
williambdean
commented
Feb 18, 2022
|
Adding v5 after noting the Altair PR. Restructured the tests to load in the data from JSON. Since the major_version is being tested, switched to public property |
|
Thank you for your effort @wd60622! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for newer vega lite version.
Had trouble rendering the boxplot mark with the current master branch