Skip to content

popup_width #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2015
Merged

popup_width #157

merged 1 commit into from
Jul 30, 2015

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jul 30, 2015

This PR makes the popup_width keyword (and docs) consistent for line, circle, polygon, and simple_marker.

NB: the simple_marker keyword changed from width to popup_width. The previous kw width was ambiguous and inconsistent.

(Closes #130.)

@ocefpaf ocefpaf mentioned this pull request Jul 30, 2015
Closed
@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 30, 2015

@themiurgo can you review and merge this one please?

@themiurgo
Copy link
Contributor

All clear!

themiurgo added a commit that referenced this pull request Jul 30, 2015
@themiurgo
Merge pull request #157 from ocefpaf/pop_width
c1d9849 
width -> popup_width
@themiurgo themiurgo merged commit c1d9849 into python-visualization:master Jul 30, 2015
@ocefpaf ocefpaf deleted the pop_width branch July 30, 2015 15:08
@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 30, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocefpaf @themiurgo