Skip to content

Merge branch 'plugins' #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 5, 2015

Conversation

BibMartin
Copy link
Contributor

No description provided.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 2, 2015

Awesome! I really like your vision for this implementation.

@themiurgo since you reviewed most of this PR how far are we from merging?

@BibMartin
Copy link
Contributor Author

@ocefpaf @themiurgo I'm a bit bolcked by this PR : if I want to go further on plugins, I don't know whether I shall commit them on the master branch or on plugins.
Do you think this can be merged soon ? Or how shall I manage the thing, please ?

PS: sorry for that (most probably) silly question.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 4, 2015

sorry for that (most probably) silly question.

Not at all! But since this is a big change lets wait for more eyes here. I am 👍

What do you say @themiurgo?

@themiurgo
Copy link
Contributor

I think either way is fine, as long as we keep master working. If you feel it's stable, merge it with master. If you want to have some more freedom to break experiment, continue on a separate branch. I am fine with either choice.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 5, 2015

Lets merge than, even if we have to breack things later. People "follow" master and we are getting PRs (#166, #152) that should be using this logic.

ocefpaf added a commit that referenced this pull request Aug 5, 2015
@ocefpaf ocefpaf merged commit a55680b into python-visualization:master Aug 5, 2015
@BibMartin BibMartin deleted the merge_with_plugins branch August 5, 2015 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants