Pre commit #1632
Merged
Pre commit #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Conengmo, b/c this PR touches several files I'll leave to you to merge it or not. |
|
Good initiative! I understand using pre-commit locally. But what is the Github Action supposed to do, will it fail if pre-commit changes something? By the way, did you see this warning? https://github.com/python-visualization/folium/actions/runs/3220435260 |
If it fails a user can fix it by reading the error message. We could configure pre-commit-ci to commit the fix but I find that very intrusive and leads to conflicts that may confuse new contributors. |
Conengmo
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1567