Bootstrap 5 #1644
Bootstrap 5 #1644
Conversation
|
All tests pass when I use the link to this feature branch. Now I'll revert it to use the future link again. Some tests will then fail, but it should be safe to merge. When merging please squash and merge. |
|
The selenium tests are failing with a 403, any idea of what is going on there? |
|
Yes, I included a CDN link to our main branch, so the files are not there yet until this PR is merged. But take a look at the |
|
Yeah. You mentioned that above and I missed it, sorry. |
Can we do a permalink or something? I don't recall what is the best practice in this case. I'm OK merging this as-is but I have a feeling we dealt with this in the past. |
|
I don't think we solved this in the past... The best way would be to merge the static dependencies first, then do a second PR that uses them. But I guess I took the liberty to cut a corner here 😇 |
|
Hmm this did break the Selenium tests on the main branch. Looking into it... |
This reverts commit 4e6e6e4.
|
Reverting this change in #1648 since there's an issue with how we use the CDN. |
|
What if we hosted those files in a new repo? We can even versioned them in that approach. |
|
Yes, that's probably best!
|
\o/ |
Replaces #1482.
Upgrading to Bootstrap 5 is not trivial, since the Awesome Marker package we use relies on Bootstrap 3 for glyphicons icons. Those are dropped in Bootstrap 4 and 5.
Maintain backwards compatibility by extracting the glyphicons css and fonts from Bootstrap 3 and including them in folium.
This way we can upgrade Bootstrap while still allowing the default icons of Awesome Marker.
TODO in a next one:
include more documentation on what icons are available.
To test this PR
In this PR I already link to the future location of the static css and fonts. If you want to test it locally, change the jsdeliver link to point to my repo and branch: https://cdn.jsdelivr.net/gh/Conengmo/folium@bootstrap-5/folium/templates/bootstrap_3_glyphicons/bootstrap-3-glyphicons.css