Skip to content

TimestampedWmsTileLayers inherit from MacroElement, not Layer. #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Conengmo
Copy link
Member

Split off from #1690.

The TimestampedWmsTileLayers plugin class currently inherits from Layer, but that doesn't make sense, it doesn't use any of it. The arguments in the docstring didn't actually appear in the init. Instead inherit from MacroElement.

@Conengmo Conengmo merged commit f743136 into python-visualization:main Jan 11, 2023
@Conengmo Conengmo deleted the timestampedwmstilelayers-not-a-layer branch January 11, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant