Skip to content

Repair tests #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 18, 2023
Merged

Repair tests #1761

merged 6 commits into from
May 18, 2023

Conversation

Conengmo
Copy link
Member

@Conengmo Conengmo commented May 17, 2023 •
edited
Loading

Seems like a new pandas version got out that deprecated some things in three notebook. Let's see if everything runs okay now.

  • Altair 5.0.0 has a fix to work with the new Pandas version, so pin that.
  • New Altair version doesn't have data built in, use the vega_datasets package instead.
  • Some notebooks needed some syntax fixes to work with the new Pandas version.
  • Don't test the code of examples/WmsTimeDimension.ipynb, the external resource makes it flaky. We already skip it in the Selenium tests.

@Conengmo
Copy link
Member Author

There’s an issue with installing the packages on Python 3.7. Since that version will be end of line soon, I’ll upgrade the workflow to 3.8.

@Conengmo
Copy link
Member Author

Everything passes! 🚀

@Conengmo Conengmo merged commit 76647fe into python-visualization:main May 18, 2023
@Conengmo Conengmo deleted the repair-tests branch May 18, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Conengmo