Fix some typos and pep8 #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
force-pushed
the
pep8
branch
2 times, most recently
from
06ad850 to
a44d452
Compare
|
Re-based and good to go. |
| @@ -404,9 +413,12 @@ def div_markers(self, locations=None, popups=None, marker_size=10, popup_width=3 | |||
| 'icon': "{'icon':"+icon_name+"}" | |||
| }) | |||
|
|
|||
| popup_out = self._popup_render(popup=popup, mk_name='div_marker_{0}_'.format(call_cnt), | |||
There was a problem hiding this comment.
Why do you fix this line like this instead of something like
mk_out = 'div_marker_{0}_'.format(call_cnt)
popup_out = self._popup_render(popup=popup, mk_name=mk_out)
?
I don't know pep8 very well, but it seems to me that it would be more understandable.
There was a problem hiding this comment.
Yep. Much better. I am just going to call it mk_name instead of mk_out to be more consist.
|
2 comments in the code ; as for the rest, it seems good to me. |
|
Ok, let's merge 🎉 |
|
Thanks. That kind of cleanup was in my TODO list for folium since day 1 (well.. It is python so day 0)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was fixing #181 and started to pep8 and fix typos... So I decided to send this as a PR first and then the actual fix. @BibMartin or @themiurgo can either of you review and merge this one?