Add ability to set font size in plot #1879
Conversation
There was a problem hiding this comment.
Thanks for your effort @this-josh! It’s a nice improvement and I’m sure we can merge it soon.
I found a typo, and I added a question, hope to hear your thinking on it.
folium/utilities.py
Outdated
| if isinstance(value, (int, float)): | ||
| return f"{value}rem" | ||
|
|
||
| if "rem" not in value: |
There was a problem hiding this comment.
Why must the unit be rem? Why not also allow px or em for example?
This behavior seems very related to https://github.com/python-visualization/branca/blob/f3d866f598a194f9acd30e24e1affe52a32a9f05/branca/utilities.py#L412, which is a generic function to parse any html/css size. (But had hardcoded ‘px’ as default unit.)
There was a problem hiding this comment.
Good point, I've updated it to accept em and px.
There was a problem hiding this comment.
Thanks! The default could still be rem if you like.
I noticed some test may fail, once that’s solved I’ll go ahead and merge it!
Co-authored-by: Frank Anema <[email protected]>
made px the default in line with _parse_size.
|
Thanks @this-josh! |
This PR permits you to set the leaflet font size. This is helpful to make plots more legible in certain circumstances.