Skip to content

Fix Stamen Toner URL to use .png as stated at maps.stamen.com. Update… #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2015

Conversation

tahmed42
Copy link
Contributor

… different attribution required specifically for Toner as also stated there.

… different attribution required specifically for Toner as also stated there.
@ocefpaf
Copy link
Member

ocefpaf commented Aug 24, 2015

At Stamen Toner I see exactly what we have now:

tiles

However, the OpenStreetMaps FAQ states:

Our requested attribution is "© OpenStreetMap contributors".
You must also make it clear that the data is available under the Open Database Licence. This can be achieved by providing a "License" or "Terms" link which links to www.openstreetmap.org/copyright or www.opendatacommons.org/licenses/odbl.

So I guess we have to change all maps attr.txt that makes reference to OpenStreetMaps!

@tahmed42 Are you willing to do that in this PR?

PS: Are there any advantages of using PNG instead of JPEG? I find that JPEGs tiles are usually easier on the bandwidth than PNGs.

Edit: OK. I just read the update and we have to change to PNG. Merging this.

ocefpaf added a commit that referenced this pull request Aug 24, 2015
Fix Stamen Toner URL to use .png as stated at maps.stamen.com. Update…
@ocefpaf ocefpaf merged commit 9219daa into python-visualization:master Aug 24, 2015
@ocefpaf
Copy link
Member

ocefpaf commented Aug 24, 2015

Thanks @tahmed42!

@tahmed42
Copy link
Contributor Author

No problem!

Weird, at maps.stamen.com, they say:
For Toner: Map tiles by Stamen Design, under CC BY 3.0. Data by OpenStreetMap, under ODbL.
For everything else: Map tiles by Stamen Design, under CC BY 3.0. Data by OpenStreetMap, under CC BY SA.

But maybe they're out of date on that and OSM requires ODbl for everything now.
Also re: png, the only reason I made the change to that is because at maps.stamen.com towards the bottom in the "Elsewhere" section, it stated:
Many applications and libraries understand the notion of map URL templates. These are ours:
http://tile.stamen.com/toner/{z}/{x}/{y}.png
http://tile.stamen.com/terrain/{z}/{x}/{y}.jpg
http://tile.stamen.com/watercolor/{z}/{x}/{y}.jpg

So it went out of its way to use png for toner and I read that as jpg not being available for it (maybe it was available in the past?). Moreover though, I noticed toner wasn't loading right in folium but with the change to png, it worked. Tested that out using the custom tileset abiilty in folium, which came in super handy.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 24, 2015

But maybe they're out of date on that and OSM requires ODbl for everything now.

Yep. I opened an issue for it #202.

@tahmed42
Copy link
Contributor Author

Ah whoops, didn't catch your comment edit before replying about pngs, haha.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 24, 2015

No problem. Thanks again for the PR!

@ocefpaf ocefpaf added the bug An issue describing unexpected or malicious behaviour label Feb 12, 2016
@ocefpaf ocefpaf added this to the v0.2.0 milestone Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected or malicious behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants