Skip to content

Fix or mitigate https://github.com/python-visualization/folium/issues… #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

sgrefen
Copy link
Contributor

@sgrefen sgrefen commented Jun 2, 2025

…/2152. CustomIcon doesn't exist (anymore?) in leaflet

@hansthen hansthen self-requested a review June 2, 2025 16:41
@hansthen
Copy link
Collaborator

hansthen commented Jun 2, 2025

I updated the commit slightly. I wanted to make it as a suggestion, but I forgot how to do that. Let me know if you are okay with my change.

Copy link
Contributor Author

@sgrefen sgrefen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work, it displays the standard Icon instead of the custom one.
image

@hansthen
Copy link
Collaborator

hansthen commented Jun 3, 2025

Indeed.

@hansthen hansthen merged commit 68f739f into python-visualization:main Jun 3, 2025
29 checks passed
@hansthen
Copy link
Collaborator

@sgrefen Thanks! Your feature is live now.

@sgrefen sgrefen deleted the is_2152 branch June 12, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants