Skip to content

Create HeatMap as suggested in #213 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2015

Conversation

BibMartin
Copy link
Contributor

@ocefpaf
Copy link
Member

ocefpaf commented Oct 30, 2015

You are on 🔥 this week!

@BibMartin
Copy link
Contributor Author

🎵 Hurray ! It's holy-holyday ! 🎵

@andrewgiessel
Copy link
Contributor

Oh yahhhh! 👍 🎉

@ocefpaf
Copy link
Member

ocefpaf commented Oct 31, 2015

heatmap

Parameters
----------
data : list of points of the form [lat, lng, weight]
The point you want to plot.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's support 3D numpy as well. We can listify them internally.

Question: In your test example you pass a 2D array and things work. I guess that we should raise an error instead, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the js library accepts arrays of shape (n,2) and (n,3) ; so we shall do the same thing. A new commit just do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the js library accepts arrays of shape (n,2) and (n,3) ; so we shall do the same thing.

OK. If the JS support let's do that then... But what is the reason? I confess I just glimpsed over the docs, but I could not find a rational for that.

@ocefpaf
Copy link
Member

ocefpaf commented Oct 31, 2015

It is all good to me. Just a minor typo and then good to go!

Thanks for the great work @BibMartin!

accept numpy.array in HeatMap
Fix typo
@BibMartin
Copy link
Contributor Author

typo fixed ; commits squashed ...

ocefpaf added a commit that referenced this pull request Oct 31, 2015
Create HeatMap as suggested in #213
@ocefpaf ocefpaf merged commit f3df0dd into python-visualization:master Oct 31, 2015
@ocefpaf
Copy link
Member

ocefpaf commented Oct 31, 2015

And merged!

@ocefpaf ocefpaf mentioned this pull request Oct 31, 2015
@BibMartin BibMartin deleted the issue213 branch December 7, 2015 11:02
@jackboot7
Copy link

Amazing work @BibMartin, just used your HeatMap plugin to generate a pretty map of geolocalized data.

Thank you!

@ocefpaf
Copy link
Member

ocefpaf commented Dec 8, 2015

Hi @jackboot7 consider sending your notebook to our "gallery."

@jackboot7
Copy link

@ocefpaf: Sure, I'll do it as soon as I'm done with my program.

@ocefpaf
Copy link
Member

ocefpaf commented Dec 8, 2015

Thanks 👍

@jackboot7
Copy link

@ocefpaf How would you prefer that I share my usage of Folium with you, guys? I made a blog post about the my use case (http://www.jackboot7.com/visualizing-tweets.html )

@ocefpaf
Copy link
Member

ocefpaf commented Dec 10, 2015

The blog reference is fine. We don't have a list of use cases right now but I want to start one.

However, if you find the time it would be nice to get a PR with that notebook in our examples folder:

https://github.com/python-visualization/folium/tree/master/examples

@ocefpaf ocefpaf added the enhancement Feature request or idea about how to make folium better label Feb 12, 2016
@ocefpaf ocefpaf added this to the v0.2.0 milestone Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or idea about how to make folium better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants