Add save and create_map methods #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| template: string, default None | ||
| Deprecated, not used anymore | ||
| """ | ||
| warnings.warn("%s is deprecated. Use %s instead" % ("Map.create_map", |
There was a problem hiding this comment.
Awesome! I was going to suggest that. I like save or save_map better than create_map.
|
Merging this one. Thanks again @BibMartin! |
ocefpaf
added a commit
that referenced
this pull request
Nov 1, 2015
Add save and create_map methods
ocefpaf
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentionned in #226.
Finally, I did a
savemethod for all elements, and acreate_mapmethod forMaponly, with a deprecation warning.