Skip to content

pep8 and typos #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2015
Merged

pep8 and typos #248

merged 1 commit into from
Nov 13, 2015

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Nov 13, 2015

@BibMartin hopefully I did not break anything.

This PR is mostly "janitorial services." Nothing new is introduced and if you think there is too much noise just close it and I will try to send it in small pieces.

@BibMartin
Copy link
Contributor

@ocefpaf
That's awesome (and I definitely have to learn PEP8 and English)!
I'm not finished with reviewing but everything seems good so far.

Please tell me ; you've got a tool to automate that, don't you ?

@BibMartin
Copy link
Contributor

It's okay. I guess it's no need to wait for further review. Let's merge.

BibMartin added a commit that referenced this pull request Nov 13, 2015
@BibMartin BibMartin merged commit 9fe7593 into python-visualization:master Nov 13, 2015
@BibMartin
Copy link
Contributor

Thank you @ocefpaf !

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 13, 2015

That's awesome (and I definitely have to learn PEP8 and English)!

Your English is better than mine!
And if you start pep8ing your code I won't have a place here 😉

Worry about awesome code and I will clean the mess after the party.

Please tell me ; you've got a tool to automate that, don't you ?

I use vim-flake8 to flag what needs changing, but the actual change is manual. I avoid autopep8.

@ocefpaf ocefpaf deleted the pep8 branch November 13, 2015 17:00
@ocefpaf ocefpaf added the bug An issue describing unexpected or malicious behaviour label Feb 12, 2016
@ocefpaf ocefpaf added this to the v0.2.0 milestone Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected or malicious behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants