Skip to content

Fix #273 #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2015
Merged

Fix #273 #275

merged 1 commit into from
Dec 2, 2015

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Dec 2, 2015

@BibMartin can you take a quick look?

PS0: We need to test the _repr_html_ to avoid this

PS1: As a self punishment I will watch wf-BqAjZb8M a 100 times 😉

@jelmelk
Copy link
Contributor

jelmelk commented Dec 2, 2015

😆 that is a great talk tho

BibMartin added a commit that referenced this pull request Dec 2, 2015
@BibMartin BibMartin merged commit 6e6f578 into python-visualization:master Dec 2, 2015
@ocefpaf ocefpaf deleted the fix_bug_273 branch December 2, 2015 20:11
@BibMartin
Copy link
Contributor

Merged. Thanks @ocefpaf.

BTW : we're using triple quote because we are lazy ; I wonder whether we shall not one day think about moving that kind of code into :

iframe = (
    '<div style="width:{width};">'
    '<div style="position:relative;width:100%;height:0;padding-bottom:{ratio};">'
    '<iframe src="{html}" style="position:absolute;width:100%;height:100%;left:0;top:0;">'
    '</iframe>'
    '</div></div>')

That way, the outputed HTML would not benefit of our python indentations.

But this is a PEP8-style PR that shall be launched when the repo is more quiet.

@ocefpaf
Copy link
Member Author

ocefpaf commented Dec 2, 2015

That way, the outputed HTML would not benefit of our python indentations.

The output HTML does need some cleanups. Tabs, white-spaces, empty lines...

But this is a PEP8-style PR that shall be launched when the repo is more quiet.

👍

@ocefpaf ocefpaf added the bug An issue describing unexpected or malicious behaviour label Feb 12, 2016
@ocefpaf ocefpaf added this to the v0.2.0 milestone Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected or malicious behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants