Consistent use of the kw attr

[ocefpaf]

We have attr originally in the Map() class. This PR makes all others kwargs attr instead of attribution.

I am not sure if we should take this opportunity and change everything to attribution instead of attr.

(At least now it is consistent.)

[ocefpaf]

@andrewgiessel Can you review and merge this one? @BibMartin and @themiurgo are you both OK with attr?

[BibMartin]

I am not sure if we should take this opportunity and change everything to attribution instead of attr.
(At least now it is consistent.)

👍 Let's go like this for the moment ; that's already a good thing

[andrewgiessel]

Yes, I will review and do the merge!

On Thu, Dec 3, 2015 at 9:36 AM Martin Journois [email protected]
wrote:

I am not sure if we should take this opportunity and change everything to
attribution instead of attr.

(At least now it is consistent.)

[image: 👍] Let's go like this for the moment ; that's already a good
thing

—
Reply to this email directly or view it on GitHub
#276 (comment)
.

[ocefpaf]

Yes, I will review and do the merge!

Thanks @andrewgiessel! We already have green from @BibMartin.

[andrewgiessel]

Looks good to me, merging.

[ocefpaf]

Did I just break my "consistency" in #348? I guess I did!