Moved plugins test to tests/plugins #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There remains 3 tests to improve. @ocefpaf you can already tell me whether the mindset is good. |
|
Finished. |
Closed
|
This one looks awesome! Thanks @BibMartin!! |
| @@ -53,8 +53,7 @@ def __init__(self, position=None, heading=0, | |||
| {% endmacro %} | |||
| """) # noqa | |||
|
|
|||
|
|
|||
| def render(self, **kwargs): | |||
| def render(self, **kwargs): | |||
There was a problem hiding this comment.
I guess that the tests found this bug 😜
|
I made a few minor comments. Ping me back when you are done. (Thanks again. We really needed this!) |
|
BTW. I am OK merging this as is if you are busy. I can make the modifications later. |
BibMartin
force-pushed
the
plugin_tests
branch
from
20cadd4 to
3e9dd99
Compare
ocefpaf
added a commit
that referenced
this pull request
Dec 22, 2015
Moved plugins test to tests/plugins
|
Thanks @BibMartin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not finished. Adresses #225 .