-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Bounds #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bounds #305
Conversation
else: | ||
return [] | ||
else: | ||
raise ValueError('List type expected {!r}'.format(x)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is better: List type expected. Got {!r}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I'll do it
Thanks @BibMartin! I made a few minor comments. Let me know once you are done so I can review it again. |
Thanks @ocefpaf for first review. I'm okay with your comments and will apply them asap.
|
@ocefpaf
We can eventually add something in
Tell me if you want I add it before squashing. |
@themiurgo I would be interested to have your point of view also ; I realize this addresses #244 in the same time as #139 . |
Sorry, coming late for this. Looks great though! :) |
Not finished. Adresses #139