Skip to content

Add period in plugins.timestamped_geojson #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2016

Conversation

BibMartin
Copy link
Contributor

Fix #325.

I had it and just forgot to do the PR.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 14, 2016

You are fast! I was still reading Leaflet.TimeDimension docs 😸

@BibMartin BibMartin force-pushed the timestamped_geojson branch from 87c0864 to 74fe76a Compare January 14, 2016 17:15
@BibMartin
Copy link
Contributor Author

@ocefpaf
Squashed and ready to go if you're okay.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 14, 2016

Awesome! BTW here is how I found the bug:

http://nbviewer.ipython.org/gist/ocefpaf/60ae6dd499381b107dcc?flush_cache=true

My first attempt to use timestamped_geojson. (It does nor work on Chrome BTW. I tested it only on Chrome and Firefox.)

ocefpaf added a commit that referenced this pull request Jan 14, 2016
Add period in plugins.timestamped_geojson
@ocefpaf ocefpaf merged commit 73c31e6 into python-visualization:master Jan 14, 2016
@ocefpaf ocefpaf added the bug An issue describing unexpected or malicious behaviour label Feb 12, 2016
@ocefpaf ocefpaf added this to the v0.2.0 milestone Feb 12, 2016
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
…d_geojson

Add period in plugins.timestamped_geojson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected or malicious behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants