[WIP] Docstring review

[BibMartin]

Starting to address #140
Hunting TODO with grep -r TODO

[ocefpaf]

@andrewgiessel Can I recruit you to review these? (As the only native English speaker I guess you are the most qualified to review docstrings 😝)

[ocefpaf]

We can drop the space between Ex and :

[BibMartin]

(suggestion + I agree) = correction

[BibMartin]

@ocefpaf
At the cost of being here ; I would like to drop features.ColorScale object in favor of colormap.ColorMap, so that we don't have to handle future deprecation warnings.

What do you think ? Can I do it in this PR, or wait for it to be merged and do another one ?

[BibMartin]

Same question about fixing #247

[ocefpaf]

Do what is most convenient. I am OK with a mixed porpuse PR.
On Jan 16, 2016 8:08 AM, "Martin Journois" [email protected] wrote:

Same question about fixing #247
#247

—
Reply to this email directly or view it on GitHub
#329 (comment)
.

[BibMartin]

✅ I think I'm done for this PR.
@ocefpaf Please tell me if you want I squash, if you're okay with all this mess.

[ocefpaf]

✅ I think I'm done for this PR.

Thanks! I will take a second look and merge it.

@ocefpaf Please tell me if you want I squash, if you're okay with all this mess.

Let's not squash this one in case we need to reference a certain commit later.

[ocefpaf]

A few extra minor comments and I am done. (BTW. I am OK with the docstings as is and I can merge without the suggestions if you do not want to change.)

[BibMartin]

Finally I removed the title to keep it simple.

If you're okay, it's ready to go.

[ocefpaf]

Awesome!