Skip to content

Complete docstrings #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2016
Merged

Complete docstrings #344

merged 2 commits into from
Feb 7, 2016

Conversation

BibMartin
Copy link
Contributor

And here it is.

@ocefpaf

Done? Never! Ready for a release? We were probably good enough a few PRs ago 😜

I was naively thinking that the work would be finished with v0.2 ... 😉

ocefpaf
ocefpaf reviewed Feb 7, 2016
View reviewed changes
folium/element.py
@@ -427,11 +452,21 @@ def __init__(self, data, width="100%", height="100%"):


class Div(Figure):
"""Create a Map with Folium and Leaflet.js.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

ocefpaf added a commit that referenced this pull request Feb 7, 2016
@ocefpaf
Merge pull request #344 from BibMartin/doctring_end
a358df3 
Complete docstrings
@ocefpaf ocefpaf merged commit a358df3 into python-visualization:master Feb 7, 2016
@ocefpaf
Copy link
Member

ocefpaf commented Feb 7, 2016

Awesome! Thanks @BibMartin!

I will take a second parse at the open issues/PRs before issuing the new release. Stay tuned...

@BibMartin
Copy link
Contributor Author

Great @ocefpaf ! You're the one that can issue the release (I don't even know what shall be done).

I may come in a few hours with another docs-filling PR, but it can be merged on the release branch I guess.

@ocefpaf
Copy link
Member

ocefpaf commented Feb 7, 2016

I don't even know what shall be done.

Nothing fancy. I just tag it on GitHub and upload the source dist to PyPI. There are projects with way more complex steps, but for now ours is still simple. We will add some complexity for publishing the docs though.

I may come in a few hours with another docs-filling PR, but it can be merged on the release branch I guess.

OK. I won't create a v0.2.0 branch until we are all set to avoid confusion. We can keep pointing PRs to master.

@BibMartin BibMartin mentioned this pull request Feb 7, 2016
Closed
@ocefpaf ocefpaf added bug An issue describing unexpected or malicious behaviour documentation Documentation about a certain topic should be added labels Feb 12, 2016
@ocefpaf ocefpaf added this to the v0.2.0 milestone Feb 12, 2016
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
@ocefpaf
Merge pull request python-visualization#344 from BibMartin/doctring_end
691d746 
Complete docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug An issue describing unexpected or malicious behaviour documentation Documentation about a certain topic should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BibMartin @ocefpaf