Skip to content

Skip Python 3.3 in Travis... #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2016
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Feb 11, 2016

... and run flake8 in all files.

@BibMartin easy review and merge.

I am skipping Python 3.3 not because it is failing, but it is a well know distribution for problems and people are recommended to upgrade. By skipping it in our Travis-CI we only get faster results.

@BibMartin
Copy link
Contributor

I'm okay with it ; but there are conflicts due to #348 merge.

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 12, 2016

Rebased! Over to you @BibMartin.

@BibMartin
Copy link
Contributor

Appart of ocefpaf@2cba9f5#commitcomment-16065272 I am okay for the rest

@ocefpaf ocefpaf force-pushed the flak8 branch 2 times, most recently from deb220f to b77f5f3 Compare February 12, 2016 17:16
@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 12, 2016

Apart of ocefpaf@2cba9f5#commitcomment-16065272 I am okay for the rest.

I think I got it now. Sorry for the noise and thanks for the review!

@BibMartin
Copy link
Contributor

Again a question...

@BibMartin
Copy link
Contributor

Ok, now.

BibMartin added a commit that referenced this pull request Feb 12, 2016
Skip Python 3.3 in Travis...
@BibMartin BibMartin merged commit fa1bf4c into python-visualization:master Feb 12, 2016
@ocefpaf ocefpaf deleted the flak8 branch February 12, 2016 17:24
@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 12, 2016

Thanks!

@ocefpaf ocefpaf added the bug An issue describing unexpected or malicious behaviour label Feb 12, 2016
@ocefpaf ocefpaf added this to the v0.2.0 milestone Feb 12, 2016
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected or malicious behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants