Try branca dependency #359
Conversation
I thought that 🚢 had already ⛵ ? 👍 |
|
This re-factor will also be a good test for our tests 😉 Have fun making Travis-CI happy! |
Yes ; I think the bug is on branca's side. I'll put an issue to them... |
BibMartin
force-pushed
the
try_branca
branch
from
b13776c to
9f68df9
Compare
|
And it works! |
👍 However, let's hold the merge until we have a first release of PS: I assign myself for reviewing this and testing the notebook later today or early tomorrow. Ping me if I fail to do so 😉 |
| @@ -16,6 +16,7 @@ before_install: | |||
| - travis_retry conda create --yes -n test python=$PYTHON --file requirements.txt | |||
| - source activate test | |||
| - conda install --yes --file requirements-dev.txt; | |||
| - pip install git+https://github.com/python-visualization/branca.git | |||
There was a problem hiding this comment.
However, let's hold the merge until we have a first release of branca. When projects are tied together like this the first dependency dictates the releases.
This line downloads and install the master of branca, meaning folium tests will run with branca's present master.
I guess this is too dangerous because it breaks tests reproducibility. But I know it's possible to ask pip for a specific commit, so that we could live (on folium's master) on a version of branca that's not necessarily released.
Depending on your reply, I'll either freeze a branca commit into this line, or create a v0.0.0 of branca and ask for it in this line.
There was a problem hiding this comment.
Depending on your reply, I'll either freeze a branca commit into this line, or create a v0.0.0 of branca and ask for it in this line.
Actually that depends on your plans. Even though I recommend a release (v0.1.0 at least), we can deal with Travis-CI to pointing master until the dust settles. I just don't want that to become a permanent thing.
So,
- if you see a fast development pace in the next few weeks leave it as-is and let's open an issue to remind us to change it later;
- if you are not going to be developing
brancafor a while and/or if you thing other might be interested into using this ASAP, then let's tag a release.
|
Finally, I've put a commit number in the
Would it be good enough ? |
Yep. Sounds good. Another idea for the long term is to split Travis-CI into two tests. One for the latest branca PS: Ready for merging? |
Yes, it can be interesting.It will widely depend on how we organize release cycles. For the moment I imagine to have a release of branca almost each time we release folium. It's not really clear in my mind today.
Yes |
|
BTW this PR just appeared under my radar: https://github.com/rhattersley/pyugrid/blob/separate-coding-checks/.travis.yml That is an example of context separation we need. |
Try branca dependency
Do not merge ; this is to test folium with a dependency to branca.
But the interest of the split has to be confirmed.