Fix #371 #372
Merged
Fix #371 #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot figure out what's going wrong with the tests (and cannot reproduce it) |
I am away in a conference. I'll take a look, merge, and backport to a PS0: since this is a bugfix we should cut a v0.2.1, but no need to wait for PS1: The failure is relate to conda and not folium. I am already looking |
|
Ok, great! no hurry, we have a workaround in #371 meanwhile. |
|
@ocefpaf Oups, it seems we forgot this one. |
ocefpaf
added a commit
that referenced
this pull request
Mar 14, 2016
|
This was disappeared from both our radars 😉 |
sanga
pushed a commit
to sanga/folium
that referenced
this pull request
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ocefpaf,
this needs to be cherry-picked on the branch
v0.2.I don't know how we should deal with this: shall we do a
v0.2.1to incorporate the fix ? wait for more bugfixes and do av0.2.1in a few weeks ?