Skip to content

HeatMap should pass "name" to super #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2016
Merged

HeatMap should pass "name" to super #380

merged 1 commit into from
Mar 9, 2016

Conversation

eddies
Copy link

@eddies eddies commented Mar 9, 2016

HeatMap wasn't passing the name argument, so the label for a heatmap in the LayerControl was defaulting to a uuid-based name.

Also, I "fixed" some dependency issues I ran into so that I could build & test folium:

  • No matching distribution found for krb5 (from -r requirements-dev.txt (line 6))
  • ImportError: No module named 'branca'

@eddies
Copy link
Author

eddies commented Mar 9, 2016

hrm. I see from the Travis failure that conda doesn't know about branca. I don't use/am only passingly familiar with conda. And perhaps krb5 is available via conda--I was only checking pypi. But in any case, all tests passed locally without krb5. And I did see @BibMartin's commit 080fc2f referencing test_geo_pandas but couldn't find said test.

I can toast f66ba6e if that's preferred, since it's not actually necessary for the fix to HeatMap.

@BibMartin
Copy link
Contributor

Thanks @eddies for your contribution.
(btw your generator-dashi looks great)

I can toast f66ba6e if that's preferred, since it's not actually necessary for the fix to HeatMap.

Yes, please remove this commit ; we're pointing to a branca commit for the moment because branca is brand new (and instable), but we'll change it before next release.

krb5 used to be necessary for installing geopandas with ioos repository. It may not be required now (if ioos fixed their geopandas distro), but I would keep it for the moment (it's installed anyway as it's a geopandas requirement).

test_geo_pandas is automatically generated by the script test_notebook.py that creates one test for each notebook in the examples folder.

@eddies
Copy link
Author

eddies commented Mar 9, 2016

Thank @BibMartin for the patient explanation. I removed f66ba6e and Travis appears happy again.

BibMartin added a commit that referenced this pull request Mar 9, 2016
HeatMap should pass "name" to super
@BibMartin BibMartin merged commit 0c67dc6 into python-visualization:master Mar 9, 2016
@BibMartin
Copy link
Contributor

Awesome; Thanks @eddies

@ocefpaf
Copy link
Member

ocefpaf commented Mar 9, 2016

👍 Thanks!

@eddies
Copy link
Author

eddies commented Mar 14, 2016

@ocefpaf if you're cutting a 0.2.1 release, would you please consider including this as well?

@ocefpaf
Copy link
Member

ocefpaf commented Mar 14, 2016

@ocefpaf if you're cutting a 0.2.1 release, would you please consider including this as well?

That is the plan 😉

sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants