Allow non-standard params on WmsTileLayer #420
Conversation
| {% if this.attribution %} attribution: '{{this.attribution}}'{% endif %} | ||
| version: '{{ this.version }}' | ||
| {% if this.attribution %}, attribution: '{{this.attribution}}'{% endif %} | ||
| {% for param in this.extra_params %}, {{param.0}}: '{{param.1}}'{% endfor %} |
There was a problem hiding this comment.
@bielfrontera thanks for the PR!
I wonder if you should be explicit here about the extra parameter instead of looping over the kwargs. What do you think @BibMartin?
There was a problem hiding this comment.
Some of the extra parameters are those included in ncWMS.
But at SOCIB we have extended that library with parameters as markerscale and markerspacing.
There was a problem hiding this comment.
@bielfrontera I am 👍 to all that. I am just concerned if we should be explicit here, by naming every option, instead of looping over the kwargs.
There was a problem hiding this comment.
@bielfrontera where do you stand on adding those parameters explicitly instead of looping over them? We also need to update the docs to describe them. At least the most important subset you expect to use frequently.
|
@bielfrontera do you mind rebasing this so we can merge it? |
bielfrontera
force-pushed
the
wmsparams
branch
from
6fceaa0 to
23c13bb
Compare
|
Hi @ocefpaf , rebase done! |
Thanks! |
|
@bielfrontera I have to apologize but this PR feel under the cracks and I merged #644 which is quite similar. Closing this but we can work out the details to get the same functionalities you expected from this one. |
I've tried to add a WMS layer with some non-standard params, but it failed because
WmsTileLayergot an unexpected keyword argument.I propose to pass any other kwarg as an option of the WMS layer that is created by folium.