Skip to content

Split branca test #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2016
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 22, 2016

This is a test to split travis into a stable released version of branca and the development version. BTW we can tell travis that one of them is "expected to fail." Not sure if that is useful here though.

@ocefpaf ocefpaf force-pushed the split_branca_test branch from 4008be9 to 82496b7 Compare May 22, 2016 11:37
@ocefpaf
Copy link
Member Author

ocefpaf commented May 22, 2016

This PR is ending a conda package. See conda-forge/staged-recipes#652

@ocefpaf ocefpaf force-pushed the split_branca_test branch from 82496b7 to cc975ab Compare July 26, 2016 03:04
@ocefpaf ocefpaf changed the title WIP :: Do not merge :: Split branca test Split branca test Jul 26, 2016
@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 26, 2016

Getting there. Testing both branca latest and release works. Now I need to fix the notebook conversion issue 😬

@ocefpaf ocefpaf force-pushed the split_branca_test branch 9 times, most recently from a2ee479 to 2b97bca Compare July 26, 2016 16:11
@ocefpaf ocefpaf force-pushed the split_branca_test branch 4 times, most recently from 01f6ab6 to 311fcca Compare July 26, 2016 16:46
@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 26, 2016

I believe the kernel specs in some of those notebook might be calling Travis-CI's Python instead of miniconda. I will refresh all the notebooks and test this...

@ocefpaf ocefpaf force-pushed the split_branca_test branch 6 times, most recently from 45a1450 to 85c8321 Compare July 26, 2016 20:20
@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 26, 2016

I had to move the notebooks tests to Python 3.5 because, for some unknown, reason the notebook tester was calling the rootPython instead of the Python in the envs. Since the env is created with Python 3.5 things are OK in this setup. One way around it would be to download the right miniconda for each Python version, but I don't think that is worth it. Running the notebook tests once is enough.

BTW only tests/test_notebooks.py::TestNotebooks::test_quickstart in the Python 3.5 TEST_TARGET=branca_latest is failing. We still need to investigate that failure, but failures in TEST_TARGET=branca_latest are fair game and the build matrix should "allow" for that.

@BibMartin this is ready for review. I will add more notebooks to the example folder later and see if we can convert them o HTML and publish them somewhere for a visual inspection of the tests.

This was referenced Jul 30, 2016
@ocefpaf ocefpaf merged commit e7f9c83 into python-visualization:master Aug 18, 2016
@ocefpaf ocefpaf deleted the split_branca_test branch August 18, 2016 10:35
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant