Skip to content

Change links from raw.githubusercontent.com to cdn.rawgit.com. #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Conversation

talespaiva
Copy link
Contributor

Change links from raw.githubusercontent.com to cdn.rawgit.com to avoid the following error:

Refused to execute script from ... because its MIME type (text/plain) is not executable, and strict MIME type checking is enabled

Following the advice in this question on StackOverflow.

@ocefpaf
Copy link
Member

ocefpaf commented Jun 2, 2016

Awesome! Thanks @talespaiva!!

@ocefpaf ocefpaf merged commit 7bad4ea into python-visualization:master Jun 2, 2016
@talespaiva
Copy link
Contributor Author

I just noticed that this modification may cause future problems. cnd.rawgit.com points to a permanent version of the file that is created in the CDN once the file is first accessed. So, if the file is changed in the project, the CDN version is not updated. Source: this thread and some tests).

The fix for this is just removing the cdn. portion of the URL.

@talespaiva
Copy link
Contributor Author

@ocefpaf Should I open a new PR?

@ocefpaf
Copy link
Member

ocefpaf commented Jun 11, 2016

@ocefpaf Should I open a new PR?

Yes please 😬

talespaiva added a commit to talespaiva/folium that referenced this pull request Jun 11, 2016
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Change links from raw.githubusercontent.com to cdn.rawgit.com.
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants