-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New plugin added: Leaflet.TextPath #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
# This is to import the repository's version of folium ; not the installed one. | ||
import sys, os | ||
sys.path.insert(0, '..') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can drop these two lines. (BTW I am planning to re-do all examples as notebooks that we can run on Travis as "visual" tests.)
Cool!
Awesome!! I made a minor comment and this LGTM (the failures are only styling/pep8ing). @BibMartin I will let this sit until next week so you get a change to look at it. Thanks @talespaiva!!! |
Removed code for running local version in example.
This is just awesome ! That's a great new feature.
I've had a look at the diffs and have seen nothing problematic.
👍 👍 👍 |
@talespaiva can you please add an entry in the changelog. |
And fix the pep8 stuff. According to travis:
|
@talespaiva this needs a rebase and some minor style fixes. I am planning a new release soon, so let me know if you have any plans on finishing this or if it is alright to pick your commits, finished it, and close this PR. |
@ocefpaf It's alright to pick my commits and finish it. I can't work in this one right now. I hope it's ok. |
Port of Leaflet.TextPath plugin: https://github.com/makinacorpus/Leaflet.TextPath
Also added examples in the plugins Jupyter notebook.