Skip to content

New plugin added: Leaflet.TextPath #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

talespaiva
Copy link
Contributor

Port of Leaflet.TextPath plugin: https://github.com/makinacorpus/Leaflet.TextPath

Example

Also added examples in the plugins Jupyter notebook.


# This is to import the repository's version of folium ; not the installed one.
import sys, os
sys.path.insert(0, '..')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop these two lines. (BTW I am planning to re-do all examples as notebooks that we can run on Travis as "visual" tests.)

@ocefpaf
Copy link
Member

ocefpaf commented Jun 17, 2016

Port of Leaflet.TextPath plugin: https://github.com/makinacorpus/Leaflet.TextPath

Cool!

Also added examples in the plugins Jupyter notebook.

Awesome!!

I made a minor comment and this LGTM (the failures are only styling/pep8ing).

@BibMartin I will let this sit until next week so you get a change to look at it.

Thanks @talespaiva!!!

Removed code for running local version in example.
@BibMartin
Copy link
Contributor

This is just awesome ! That's a great new feature.
BTW I'm happy to see someone adding a plugin

@BibMartin I will let this sit until next week so you get a change to look at it.

I've had a look at the diffs and have seen nothing problematic.
@ocefpaf I let you end up with the merge 😉
@talespaiva I guess you can squash your commits.

Thanks @talespaiva!!!

👍 👍 👍

@ocefpaf
Copy link
Member

ocefpaf commented Jun 17, 2016

@talespaiva can you please add an entry in the changelog.

@BibMartin
Copy link
Contributor

And fix the pep8 stuff. According to travis:

./examples/polyline_text_path_example.py:5:20: E231 missing whitespace after ','
./examples/polyline_text_path_example.py:6:101: E501 line too long (107 > 100 characters)
./examples/polyline_text_path_example.py:7:14: E128 continuation line under-indented for visual indent
./examples/polyline_text_path_example.py:8:101: E501 line too long (106 > 100 characters)
./examples/polyline_text_path_example.py:9:101: E501 line too long (106 > 100 characters)
./examples/polyline_text_path_example.py:15:101: E501 line too long (121 > 100 characters)
./examples/polyline_text_path_example.py:19:101: E501 line too long (135 > 100 characters)
./examples/polyline_text_path_example.py:20:22: E231 missing whitespace after ':'
./examples/polyline_text_path_example.py:20:42: E231 missing whitespace after ':'
./examples/polyline_text_path_example.py:21:101: E501 line too long (101 > 100 characters)
./folium/plugins/polyline_text_path.py:19:101: E501 line too long (120 > 100 characters)
./folium/plugins/polyline_text_path.py:47:101: E501 line too long (117 > 100 characters)
./tests/plugins/test_polyline_text_path.py:16:101: E501 line too long (111 > 100 characters)
./tests/plugins/test_polyline_text_path.py:17:101: E501 line too long (106 > 100 characters)
./tests/plugins/test_polyline_text_path.py:18:101: E501 line too long (115 > 100 characters)
./tests/plugins/test_polyline_text_path.py:19:101: E501 line too long (115 > 100 characters)
./tests/plugins/test_polyline_text_path.py:22:5: E303 too many blank lines (2)
./tests/plugins/test_polyline_text_path.py:24:101: E501 line too long (101 > 100 characters)

@ocefpaf
Copy link
Member

ocefpaf commented Jul 29, 2016

@talespaiva this needs a rebase and some minor style fixes. I am planning a new release soon, so let me know if you have any plans on finishing this or if it is alright to pick your commits, finished it, and close this PR.

@talespaiva
Copy link
Contributor Author

@ocefpaf It's alright to pick my commits and finish it. I can't work in this one right now. I hope it's ok.

ocefpaf pushed a commit to ocefpaf/folium that referenced this pull request Jul 30, 2016
ocefpaf added a commit to ocefpaf/folium that referenced this pull request Jul 30, 2016
@ocefpaf ocefpaf mentioned this pull request Jul 30, 2016
ocefpaf pushed a commit to ocefpaf/folium that referenced this pull request Jul 30, 2016
ocefpaf added a commit to ocefpaf/folium that referenced this pull request Jul 30, 2016
ocefpaf pushed a commit to ocefpaf/folium that referenced this pull request Sep 22, 2016
@ocefpaf ocefpaf closed this in 591b83a Sep 22, 2016
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants