Skip to content

Removed deprecated methods from examples and code snippets #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 28, 2016
Merged

Removed deprecated methods from examples and code snippets #457

merged 6 commits into from
Jun 28, 2016

Conversation

glfharris
Copy link
Contributor

Brought a couple of the examples and the readme into the new methods scheme. As the underlying functionality is the same, this is mostly just for convenience/aesthetics. Just removes some confusion from people using folium for the first time.

Also altered the data paths for the Antartic shelf example so that it now functions. At a guess this was left over from a previous file structure.

@ocefpaf
Copy link
Member

ocefpaf commented Jun 28, 2016

Awesome PR! Thanks @glfharris!!

@ocefpaf
Copy link
Member

ocefpaf commented Jun 28, 2016

The failures are only pep8 compliance stuff:

1.48s$ find . -type f -name "*.py" ! -name 'conf.py' | xargs flake8 --max-line-length=100
./examples/choropleth_states.py:17:17: E128 continuation line under-indented for visual indent
./examples/choropleth_states.py:18:17: E128 continuation line under-indented for visual indent
./examples/choropleth_states.py:19:17: E128 continuation line under-indented for visual indent
./examples/choropleth_states.py:20:17: E128 continuation line under-indented for visual indent
./examples/choropleth_states.py:26:18: E128 continuation line under-indented for visual indent
./examples/choropleth_states.py:27:18: E128 continuation line under-indented for visual indent
./examples/choropleth_states.py:28:18: E128 continuation line under-indented for visual indent
./examples/choropleth_states.py:29:18: E128 continuation line under-indented for visual indent
./examples/choropleth_states.py:30:18: E128 continuation line under-indented for visual indent
./examples/choropleth_states.py:31:18: E128 continuation line under-indented for visual indent

@glfharris
Copy link
Contributor Author

Accidentally altered the wrong file, but reverted. choropleth_counties.py has some issues with key errors, but that requires digging down into the data source, which is why I haven't touched it.

PEP8 formatting should be fixed.

Cheers!

@ocefpaf
Copy link
Member

ocefpaf commented Jun 28, 2016

The remaining issue has nothing to do with your PR and I will fix that later. Thanks again @glfharris!

@ocefpaf ocefpaf merged commit a52e6d7 into python-visualization:master Jun 28, 2016
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Removed deprecated methods from examples and code snippets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants