add options to fullscreen plugin #468
Conversation
| @@ -4,6 +4,7 @@ | |||
| from folium.plugins import Fullscreen | |||
|
|
|||
| m = folium.Map(location=[41.9, -97.3], zoom_start=4) | |||
| Fullscreen().add_to(m) | |||
| Fullscreen(position = 'topright', title = 'Expand me', titleCancel = 'Exit me', | |||
| forceSeparateButton = True).add_to(m) | |||
There was a problem hiding this comment.
We are enforcing pep8. That menas you will need to remove the spaces in the operators:
e.g.: position = 'topright' → position='topright'
and the indentation, like aligning the forceSeparateButton with the position above, note that this should be automatic in many text editors.
There was a problem hiding this comment.
Ok, I see, I will follow that.
qingkaikong
force-pushed
the
add_options_to_fullscreen_plugin
branch
2 times, most recently
from
ae3d4d3 to
330668b
Compare
|
It seems it failed because of the test_fullscreen.py, it has the assertion that need to be changed, since we added the options, I will try to do this tonight. |
qingkaikong
force-pushed
the
add_options_to_fullscreen_plugin
branch
from
330668b to
4b4ffef
Compare
qingkaikong
force-pushed
the
add_options_to_fullscreen_plugin
branch
from
4b4ffef to
ab09288
Compare
|
Ok, now I fixed the test_fullscreen.py, so it passed the test. But there's still 1 failing seems related with the notebooks, but my PR should work now. |
|
I will take a look at the notebook failure later, but yours seems good to go. |
|
Merging this as the issue is unrelated to the PR. Thanks @qingkaikong! Hope you had a nice flight back home!! |
|
Thanks Filipe, I just came back to Berkeley! Thank you so much for help me start to I will try to contribute more to folium in the future. best On Sun, Jul 17, 2016 at 1:47 PM, Filipe [email protected] wrote:
Qingkai KONG |
…ons_to_fullscreen_plugin add options to fullscreen plugin
This PR is to add options to the fullscreen plugin, including: position, title, titleCancel, and forceSeparateButton.