Update folium_vincent_markers.py #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code has been commented to show the changes.
ocefpaf
reviewed
Sep 16, 2016
| @@ -17,7 +17,9 @@ | |||
| # Binned wind speeds for NOAA 46050. | |||
| bins = range(0, 13, 1) | |||
| cuts = pd.cut(NOAA_46050['wind_speed_cwind (m/s)'], bins) | |||
| ws_binned = pd.value_counts(cuts).reindex(cuts.levels) | |||
| #ws_binned = pd.value_counts(cuts).reindex(cuts.values.levels) # cuts is a series, so values should be accessed | |||
| # and also levels have been depreciated | |||
There was a problem hiding this comment.
No need to comment it out. You may just remove and we can rely on git's history to check the changes.
| # The example of Vincent/Vega Markers should be updated | ||
| # https://github.com/python-visualization/folium | ||
| buoy_map = folium.Map(location=[46.3014, -123.7390], zoom_start=7,tiles='Stamen Terrain') | ||
| popup1 = folium.Popup(max_width=800,).add_child(folium.Vega(vis1, width=500, height=250)) |
|
@YasminFathy do you want to try to convert this example to a Jupyter notebook? |
|
Thanks @ocefpaf |
|
Thanks @YasminFathy for the contribution! I am merging this as-is and I will fix the linter errors in another PR. Feel free to try the Jupyter conversion any time 😉 |
sanga
pushed a commit
to sanga/folium
that referenced
this pull request
Oct 24, 2017
Update folium_vincent_markers.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code has been commented to show the changes.