Skip to content

Use leaflet 1.0.0 #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2016
Merged

Conversation

juoceano
Copy link
Contributor

@juoceano juoceano commented Oct 20, 2016

Fixes #521

Tested all the notebooks in the gallery locally and, with a quick visual inspection, they seems to be OK.

@juoceano
Copy link
Contributor Author

Tested all the notebooks in the gallery locally and, with a quick visual inspection, they seems to be OK.

Spoke too soon. MarkedCluster was nor working... There may be more failures. Do not merge it yet. I will check this with more care tomorrow.

@juoceano
Copy link
Contributor Author

leaflet.makercluster is redefined in many places... Maybe that deserves some re-factoring and defining it in a single place.

@juoceano
Copy link
Contributor Author

Commit 584523e fixes the polyline_text_path.

@ocefpaf ocefpaf merged commit 91b32f2 into python-visualization:master Oct 21, 2016
@ocefpaf
Copy link
Member

ocefpaf commented Oct 21, 2016

Awesome! I tested this locally and found a few more incompatibilities. See #534 but I guess we can merge this and work on that in a separate PR.

@juoceano juoceano deleted the use_leaflet_1 branch October 21, 2016 17:12
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants